Skip to content

Conversation

frrist
Copy link
Member

@frrist frrist commented May 6, 2022

closes #658
removes deprecated xerrors methods replacing them with fmt error methods

@frrist frrist requested review from placer14 and kasteph May 6, 2022 17:43
@frrist frrist self-assigned this May 6, 2022
@frrist frrist force-pushed the frrist/update-lotusv1.15.2 branch from 0a22b5b to 4b1c7e8 Compare May 6, 2022 18:48
@frrist frrist force-pushed the frrist/update-lotusv1.15.2 branch from 4b1c7e8 to 0db5730 Compare May 6, 2022 19:03
Copy link
Contributor

@kasteph kasteph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💮 🚀

Copy link
Contributor

@placer14 placer14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look through all of these changes. if it's literally a mechanical change from xerrors to fmt, then I will blindly approve. If there are important parts to review, please LMK.

@placer14
Copy link
Contributor

placer14 commented May 9, 2022

FWIW, I did review the lotus update commit and it looked GTM

@frrist frrist merged commit 6919649 into master May 9, 2022
@frrist frrist deleted the frrist/update-lotusv1.15.2 branch May 9, 2022 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watch jobs don't stop correctly
3 participants