This repository has been archived by the owner on Aug 23, 2021. It is now read-only.
#24 Put browser clients on the same libp2p network as Storage Miners #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
ionutiorgulescu
approved these changes
Sep 22, 2020
brunolm
approved these changes
Sep 23, 2020
Comment on lines
+33
to
37
| // ToDo: remove these lines at cleanup | ||
| // const rendezvousProtocol = /^\d+\.\d+\.\d+\.\d+$/.test(rendezvousIp) ? 'ip4' : 'dns4'; | ||
| // const rendezvousWsProtocol = `${rendezvousPort}` === '443' ? 'wss' : 'ws'; | ||
| // const rendezvousAddress = `/${rendezvousProtocol}/${rendezvousIp}/tcp/${rendezvousPort}/${rendezvousWsProtocol}/p2p-webrtc-star`; | ||
|
|
There was a problem hiding this comment.
Suggested change
| // ToDo: remove these lines at cleanup | |
| // const rendezvousProtocol = /^\d+\.\d+\.\d+\.\d+$/.test(rendezvousIp) ? 'ip4' : 'dns4'; | |
| // const rendezvousWsProtocol = `${rendezvousPort}` === '443' ? 'wss' : 'ws'; | |
| // const rendezvousAddress = `/${rendezvousProtocol}/${rendezvousIp}/tcp/${rendezvousPort}/${rendezvousWsProtocol}/p2p-webrtc-star`; |
|
Not sure if in scope here, but if the |
ghost
mentioned this pull request
ghost
approved these changes
Sep 23, 2020
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.