Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor "filer/tests/spec/fs.mkdir.spec.js" to follow ES6 syntax with "const/let" instead of "var" #672

Closed
2 tasks done
oleksii-polovyi opened this issue Jan 25, 2019 · 2 comments
Closed
2 tasks done

Refactor "filer/tests/spec/fs.mkdir.spec.js" to follow ES6 syntax with "const/let" instead of "var" #672

oleksii-polovyi opened this issue Jan 25, 2019 · 2 comments
Assignees
@oleksii-polovyi

Comments

@oleksii-polovyi
Copy link
Contributor

oleksii-polovyi commented Jan 25, 2019 •
edited
Loading

fs.mkdir.spec.js file contains var declarations

In order to follow ES6 standards, the following changes are required:

  • Refactor the code to use let and const instead of var
  • Invoke a strict mode
@humphd
Copy link
Contributor

humphd commented Jan 25, 2019

Sounds good, go for it @ApolllonDev.

@oleksii-polovyi
Copy link
Contributor Author

#722

@oleksii-polovyi oleksii-polovyi mentioned this issue Feb 1, 2019
Closed
humphd pushed a commit that referenced this issue Feb 5, 2019
@oleksii-polovyi @humphd
Fix issue #672 : Refactor "filer/tests/spec/fs.mkdir.spec.js" to foll…
317cee5 
…ow ES6 syntax with "const/let" instead of "var" (#722)

* Solution for issue-672

* Removed extra 'use strict';
@humphd humphd closed this as completed Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleksii-polovyi oleksii-polovyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@humphd @oleksii-polovyi