Fix issue #672 : Refactor "filer/tests/spec/fs.mkdir.spec.js" to follow ES6 syntax with "const/let" instead of "var" #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #722 +/- ##
=======================================
Coverage 86.71% 86.71%
=======================================
Files 16 16
Lines 1746 1746
=======================================
Hits 1514 1514
Misses 232 232Continue to review full report at Codecov.
|
humphd
approved these changes
Feb 5, 2019
| @@ -88,7 +89,7 @@ describe('fs.promises.mkdir', function () { | |||
| }); | |||
|
|
|||
| it('should return a promise', function () { | |||
| var fs = util.fs(); | |||
| const fs = util.fs(); | |||
| expect(fs.promises.mkdir('/tmp')).to.be.a('promise'); | |||
| }); | |||
| }); | |||
There was a problem hiding this comment.
One tip: it's a good idea to always include a newline at the end of all your files (I know this isn't your mistake, it was already like this). We do this, and GitHub shows its absence, because we want to avoid having concatenated files break when the end of one file and the start of another get joined. Just a tip for next time.
There was a problem hiding this comment.
Sounds good, will do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strict modeletandconstinstead ofvar