Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #672 : Refactor "filer/tests/spec/fs.mkdir.spec.js" to follow ES6 syntax with "const/let" instead of "var" #722

merged 2 commits into from Feb 5, 2019


None yet
3 participants
Copy link

ApolllonDev commented Jan 30, 2019

  • Invoked a strict mode
  • Refactored the code to use let and const instead of var

This comment has been minimized.

Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #722 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #722   +/-   ##
  Coverage   86.71%   86.71%           
  Files          16       16           
  Lines        1746     1746           
  Hits         1514     1514           
  Misses        232      232

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...a5f4912. Read the comment docs.


humphd approved these changes Feb 5, 2019

Copy link

humphd left a comment

Nice work, this is great.

@@ -88,7 +89,7 @@ describe('fs.promises.mkdir', function () {

it('should return a promise', function () {
var fs = util.fs();
const fs = util.fs();

This comment has been minimized.


humphd Feb 5, 2019


One tip: it's a good idea to always include a newline at the end of all your files (I know this isn't your mistake, it was already like this). We do this, and GitHub shows its absence, because we want to avoid having concatenated files break when the end of one file and the start of another get joined. Just a tip for next time.

This comment has been minimized.


ApolllonDev Feb 5, 2019

Author Contributor

Sounds good, will do.

@humphd humphd merged commit 317cee5 into filerjs:master Feb 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.