Terminal opened by Files doesn't update its environment variables with each launch

[starkgate]

Description

Terminal opened by Files doesn't update its environment variables upon launch.

Steps To Reproduce

1. Open Files
2. Set an environment variable through the System properties > Environment variables dialog
3. Open a terminal from within Files
4. Try to access the newly added variable

Expected behavior

The expected behaviour for a terminal is to read the environment variables on startup of the terminal, not of the application launching it (Files).

Files Version

Version: 2.0.13.0

Windows Version

OS Version: 10.0.19043.1288

Relevant Assets

No response

[gave92]

I'm pretty sure that's normal behavior, environment variables set in the system dialog are refreshed on windows reboot only.
Does it work differently if you launch the terminal from the start menu instead of Files?

** Edit: ah I'm afraid the new process is inheriting env variables (old) from Files. We need to read them again when starting the terminal, e.g:

psi.EnvironmentVariables.Clear();
foreach (DictionaryEntry ent in Environment.GetEnvironmentVariables(EnvironmentVariableTarget.Machine))
    psi.EnvironmentVariables[(string)ent.Key] = (string)ent.Value;
foreach (DictionaryEntry ent in Environment.GetEnvironmentVariables(EnvironmentVariableTarget.User))
    psi.EnvironmentVariables[(string)ent.Key] = (string)ent.Value;

[yaira2]

This issue should be resolved with #6663.