Skip to content

Conversation

QuaintMako
Copy link
Contributor

@QuaintMako QuaintMako commented Sep 22, 2022

Resolved / Related Issues

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots

Initial size:
initialSize

New size:
newSize

d2dyno1
d2dyno1 previously approved these changes Sep 22, 2022
@files-community files-community locked and limited conversation to collaborators Sep 22, 2022
@yaira2
Copy link
Member

yaira2 commented Sep 22, 2022

Locking for now as issue wasn't approved yet

@files-community files-community unlocked this conversation Sep 22, 2022
@yaira2 yaira2 changed the title Reducing shortcut icon size in column view Feature: Reduced shortcut icon size in column view Sep 22, 2022
@yaira2 yaira2 changed the title Feature: Reduced shortcut icon size in column view Feature: Reduced shortcut overlay size in column view Sep 22, 2022
@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Sep 22, 2022
@yaira2 yaira2 added needs - code review and removed changes requested Changes are needed for this pull request labels Sep 23, 2022
@yaira2 yaira2 self-requested a review September 23, 2022 17:07
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Sep 29, 2022
@yaira2 yaira2 merged commit 0cf46aa into files-community:main Sep 29, 2022
@QuaintMako QuaintMako deleted the 7055_ReducingShortcutIconColumnView branch September 30, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Shortcut overlay is very large in the Column layout
3 participants