-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Feature: Added option to change default layout mode #10089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ferrariofilippo can you look this over? I want to get it merged before #10117. This requires some stress testing, try to break it 🙂 |
I tried everything I thought of, and it seems the only bug is the one we already know. I think the user should be able to decide even among grid layout sizes.
I think this should be changed because a user would need to do all the above only to change the default items' size for the grid layout. |
There are a range of sizes for the grid layouts, perhaps we can support a couple presets in the drop down (small, medium, large). I'm not sure how to do that right now as we don't have enums for those. |
I think that's enough. |
Merged this as is so that we can merge the default column options, should be okay if we add the options later on. |
Yes, after all it's working with no bugs. |
if (!userSettingsService.PreferencesSettingsService.ForceLayoutPreferencesOnAllDirectories | ||
&& folderSettings.IsAdaptiveLayoutEnabled | ||
&& !folderSettings.IsLayoutModeFixed | ||
&& folderSettings.LayoutMode == FolderLayoutModes.Adaptive) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this prevents adaptive layout mode from working because folderSettings.LayoutMode is never set to Adaptive. Even in adaptive mode folderSettings.LayoutMode is still either details or grid or tiles. The above check for IsAdaptiveLayoutEnabled is what we want.
Resolved / Related Issues
Items resolved / related issues by this PR.
Validation
How did you test these changes?
Screenshots (optional)
Add screenshots here.