Skip to content

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Comments
I removed "move" option from all sidebar items that are not in the Favourite Section (I think this is the expected behavior)

Validation
How did you test these changes?

  • Built and ran the app

@QuaintMako
Copy link
Contributor

I don't know but the expected behavior, but codewise, LGTM.

@yaira2 yaira2 changed the title Fixed: Sidebar Tags Section shows "move" option Fix: Fixed issue where tags section showed "move" option Oct 14, 2022
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Oct 14, 2022
@yaira2 yaira2 merged commit 07b60d3 into files-community:main Oct 14, 2022
@ferrariofilippo ferrariofilippo deleted the Remove_Tags_Move_Option branch October 14, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Sidebar tags section shows "move" options
3 participants