Feature: Added extract archive button inside archives #10243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuaintMako
reviewed
Oct 18, 2022
ferrariofilippo
commented
Oct 18, 2022
yaira2
changed the title
yaira2
added
ready to merge
|
I noticed you added an option to open the destination folder when complete. I really like this added touch! It appears that the toolbar button to extract the archive is still visible after it navigates to the extracted items. |
Actually this feature already existed before my commit. |
1 task
yaira2
pushed a commit
that referenced
this pull request
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Items resolved / related issues by this PR.
Comments
I recycled the existing code and adapted it so that it works in both cases (inside and outside archives).
If you think I should implement this feature with brand new code, I'll find another workaround.
Validation
How did you test these changes?