Skip to content

Conversation

cinqmilleans
Copy link
Contributor

@cinqmilleans cinqmilleans commented Oct 25, 2022

Resolved / Related Issues
In the sidebar, the context menu may not be entirely visible. This pr changes its placement so that it is no longer obscured by the edge of the window.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Before
ContextBefore
After
ContextAfter

@yaira2 yaira2 changed the title Fix sidebar context menu position Fix: Fixed issue where the sidebars right click menu would sometimes get cut off Oct 25, 2022
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 26, 2022
@yaira2 yaira2 merged commit ab86dca into files-community:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants