Skip to content

Conversation

cinqmilleans
Copy link
Contributor

@cinqmilleans cinqmilleans commented Oct 29, 2022

Resolved / Related Issues
Items in File in use model are shown twice. Do not add Final to Items of the same instance but to a new instance, like other commands. Otherwise, both Items and Final are displayed.
Fixes #10321.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@yaira2
Copy link
Member

yaira2 commented Oct 30, 2022

Can you link to a GitHub issue?

@cinqmilleans
Copy link
Contributor Author

Merge fixed. Fix #10321.

@yaira2
Copy link
Member

yaira2 commented Oct 30, 2022

I think the description needs to say Closes # or alternatively Fixes # in order to properly link to the issue.

@yaira2 yaira2 changed the title Fix delete warning Fix: Fixed issue where delete modal displayed duplicate items Oct 30, 2022
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

QuaintMako
QuaintMako previously approved these changes Oct 31, 2022
…perations.cs

Co-authored-by: Quaint Mako <110472580+QuaintMako@users.noreply.github.com>
@yaira2 yaira2 requested a review from QuaintMako October 31, 2022 20:16
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 31, 2022
@yaira2 yaira2 merged commit 98d96aa into files-community:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Items in File in use model are shown twice
3 participants