Fix: Use date from Windows culture instead of Files culture #10324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuaintMako
reviewed
Oct 29, 2022
src/Files.App/ServicesImplementation/DateTimeFormatter/AbstractDateTimeFormatter.cs
Outdated
Show resolved
Hide resolved
QuaintMako
previously approved these changes
Oct 29, 2022
QuaintMako
approved these changes
Oct 29, 2022
|
@cinqmilleans can link you link this to an issue? |
yaira2
changed the title
|
This doesn't appear to resolve #10320 🤔 |
|
Sure enough, I only saw the dates issue, but not the Type column issue. I was able to reproduce the problem and I will prepare a fix. However it seems that this is another problem and it will be another pr. |
|
Seems like two separate issues, LGTM. |
yaira2
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Some dates may display in the Windows culture (language and format) instead of the Files culture. This is fixed.
The issue mentions other location issues. These are special folders whose names are provided by Windows. We cannot modify these texts according to the language in a simple way. I think it is useless to replace these texts according to the language.
Validation
How did you test these changes?