Code Quality: Refactored TerminalController #10358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
changed the title
QuaintMako
reviewed
Oct 31, 2022
QuaintMako
reviewed
Oct 31, 2022
QuaintMako
reviewed
Oct 31, 2022
QuaintMako
reviewed
Oct 31, 2022
|
We want to completely get rid of the controller (should be merged with the ViewModel) as it doesn't fit the rest of the code architecture. |
yaira2
reviewed
Nov 1, 2022
yaira2
added
ready to merge
yaira2
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Modify TerminalController, fixed warnings, code more readable,
Validation
How did you test these changes?