Skip to content

Fix: Fixed issue where OEM plus key for Alt+Shift++ (New pane) wasn't working #10405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 7, 2022
Merged

Fix: Fixed issue where OEM plus key for Alt+Shift++ (New pane) wasn't working #10405

merged 3 commits into from
Nov 7, 2022

Conversation

manfromarce
Copy link
Contributor

The New Pane keyboard shortcut (Alt+Shift++) is now also executed with the "oem" plus key, in addition to the numpad plus key.

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

QuaintMako
QuaintMako reviewed Nov 5, 2022
View reviewed changes
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a few changes to make the code cleaner, thanks a lot for your contribution!

I cannot test the function on Files for the moment sadly.

QuaintMako
QuaintMako previously approved these changes Nov 5, 2022
View reviewed changes
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the changes!

yaira2
yaira2 reviewed Nov 6, 2022
View reviewed changes
yaira2
yaira2 requested changes Nov 6, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but there is a coupe of spacing issues, can you make sure you have the file set to use tabs?

@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Nov 6, 2022
@manfromarce
Copy link
Contributor Author

Code looks good but there is a coupe of spacing issues, can you make sure you have the file set to use tabs?

Yes, I didn't notice it was "mixed". It should be fixed now

@manfromarce manfromarce requested a review from yaira2 November 7, 2022 12:53
@yaira2 yaira2 changed the title Implement Oem plus key for Alt+Shift++ (New pane) shortcut Fix: Fixed issue where OEM plus key for Alt+Shift++ (New pane) wasn't working Nov 7, 2022
yaira2
yaira2 approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Nov 7, 2022
@yaira2 yaira2 merged commit 476b259 into files-community:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

+1 more reviewer

@QuaintMako QuaintMako QuaintMako left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Alt+Shift++" shortcut only works with Numpad Plus key
3 participants
@manfromarce @yaira2 @QuaintMako