Code Quality : Removal of dead code and types

src/Files.App/Constants.cs

@@ -50,12 +50,6 @@ public static class ImageRes
 			public const int Folder = 3;
 		}
 
-		public static class Shell32
-		{
-			// See shell32.dll for more icon indexes to add
-			public const int QuickAccess = 51380;
-		}
-
 		public static class FluentIconsPaths
 		{
 			public const string CloudDriveIcon = "ms-appx:///Assets/FluentIcons/CloudDrive.png";
@@ -181,19 +175,6 @@ public static class PreviewPane
 			public const int FolderPreviewThumbnailCount = 10;
 		}
 
-		public static class PaneContent
-		{
-			public const string ContentKey = "PaneContent";
-
-			public const string HorizontalSizePxKey = "PaneHorizontalSizePx";
-
-			public const string VerticalSizePxKey = "PaneVerticalSizePx";
-
-			public const string MediaVolumeKey = "PaneMediaVolume";
-
-			public const string ShowPreviewOnlyKey = "ShowPreviewOnly";
-		}
-
 		public static class ResourceFilePaths
 		{
 			/// <summary>

src/Files.App/Converters/Converters.cs

@@ -88,8 +88,7 @@ public abstract class ValueConverter<TSource, TTarget>
 	/// <summary>
 	/// The base class for converting instances of type T to object and vice versa.
 	/// </summary>
-	public abstract class ToObjectConverter<T>
-		: ValueConverter<T?, object?>
+	public abstract class ToObjectConverter<T> : ValueConverter<T?, object?>
 	{
 		/// <summary>
 		/// Converts a source value to the target type.

src/Files.App/DataModels/SidebarPinnedModel.cs

@@ -179,17 +179,6 @@ public int IndexOfItem(INavigationControlItem locationItem)
 			}
 		}
 
-		/// <summary>
-		/// Returns the index of the location item in the collection containing Navigation control items
-		/// </summary>
-		/// <param name="locationItem">The location item</param>
-		/// <param name="collection">The collection in which to find the location item</param>
-		/// <returns>Index of the item</returns>
-		public int IndexOfItem(INavigationControlItem locationItem, List<INavigationControlItem> collection)
-		{
-			return collection.IndexOf(locationItem);
-		}
-
 		/// <summary>
 		/// Saves the model
 		/// </summary>

src/Files.App/Filesystem/FilesystemOperations/FilesystemItemType.cs

@@ -1,5 +1,3 @@
-using System;
-
 namespace Files.App.Filesystem
 {
 	public enum FilesystemItemType : byte
@@ -14,12 +12,6 @@ public enum FilesystemItemType : byte
 		/// </summary>
 		File = 1,
 
-		/// <summary>
-		/// The item is a symlink
-		/// </summary>
-		[Obsolete("The symlink has no use for now here.")]
-		Symlink = 2,
-
 		/// <summary>
 		/// The item is a library
 		/// </summary>

src/Files.App/Filesystem/FilesystemOperations/FilesystemOperations.cs

@@ -20,16 +20,8 @@
 
 namespace Files.App.Filesystem
 {
-	public enum ImpossibleActionResponseTypes
-	{
-		Skip,
-		Abort
-	}
-
 	public class FilesystemOperations : IFilesystemOperations
 	{
-		private IDialogService DialogService { get; } = Ioc.Default.GetRequiredService<IDialogService>();
-
 		private IShellPage associatedInstance;
 
 		private RecycleBinHelpers recycleBinHelpers;

src/Files.App/Filesystem/FilesystemOperations/Helpers/FilesystemHelpers.cs

@@ -161,9 +161,6 @@ public async Task<ReturnResult> DeleteItemsAsync(IEnumerable<IStorageItemWithPat
 
 			var token = banner.CancellationToken;
 
-			var sw = new Stopwatch();
-			sw.Start();
-
 			IStorageHistory history = await filesystemOperations.DeleteItemsAsync((IList<IStorageItemWithPath>)source, banner.Progress, banner.ErrorCode, permanently, token);
 			((IProgress<float>)banner.Progress).Report(100.0f);
 			await Task.Yield();
@@ -177,7 +174,6 @@ public async Task<ReturnResult> DeleteItemsAsync(IEnumerable<IStorageItemWithPat
 			source.ForEach(x => App.JumpList.RemoveFolder(x.Path)); // Remove items from jump list
 
 			banner.Remove();
-			sw.Stop();
 
 			PostBannerHelpers.PostBanner_Delete(source, returnStatus, permanently, token.IsCancellationRequested, itemsDeleted);
 
@@ -215,9 +211,6 @@ public async Task<ReturnResult> RestoreItemsFromTrashAsync(IEnumerable<IStorageI
 			var errorCode = new Progress<FileSystemStatusCode>();
 			errorCode.ProgressChanged += (s, e) => returnStatus = returnStatus < ReturnResult.Failed ? e.ToStatus() : returnStatus;
 
-			var sw = new Stopwatch();
-			sw.Start();
-
 			IStorageHistory history = await filesystemOperations.RestoreItemsFromTrashAsync((IList<IStorageItemWithPath>)source, (IList<string>)destination, null, errorCode, cancellationToken);
 			await Task.Yield();
 
@@ -227,8 +220,6 @@ public async Task<ReturnResult> RestoreItemsFromTrashAsync(IEnumerable<IStorageI
 			}
 			int itemsMoved = history?.Source.Count ?? 0;
 
-			sw.Stop();
-
 			return returnStatus;
 		}
 
@@ -454,9 +445,6 @@ public async Task<ReturnResult> MoveItemsAsync(IEnumerable<IStorageItemWithPath>
 				return ReturnResult.Cancelled;
 			}
 
-			var sw = new Stopwatch();
-			sw.Start();
-
 			itemManipulationModel?.ClearSelection();
 
 			IStorageHistory history = await filesystemOperations.MoveItemsAsync((IList<IStorageItemWithPath>)source, (IList<string>)destination, collisions, banner.Progress, banner.ErrorCode, token);
@@ -483,7 +471,6 @@ public async Task<ReturnResult> MoveItemsAsync(IEnumerable<IStorageItemWithPath>
 			source.ForEach(x => App.JumpList.RemoveFolder(x.Path)); // Remove items from jump list
 
 			banner.Remove();
-			sw.Stop();
 
 			PostBannerHelpers.PostBanner_Move(source, destination, returnStatus, token.IsCancellationRequested, itemsMoved);
 

src/Files.App/Filesystem/FilesystemOperations/ShellFilesystemOperations.cs

@@ -29,8 +29,6 @@ public class ShellFilesystemOperations : IFilesystemOperations
 
 		private RecycleBinHelpers recycleBinHelpers;
 
-		private IDialogService DialogService { get; } = Ioc.Default.GetRequiredService<IDialogService>();
-
 		#endregion Private Members
 
 		#region Constructor

src/Files.App/Filesystem/ListedItem.cs

@@ -422,15 +422,6 @@ public BaseStorageFile ItemFile
 
 		public string Key { get; set; }
 
-		/// <summary>
-		/// Manually check if a folder path contains child items,
-		/// updating the ContainsFilesOrFolders property from its default value of true
-		/// </summary>
-		public void UpdateContainsFilesFolders()
-		{
-			ContainsFilesOrFolders = FolderHelpers.CheckForFilesFolders(ItemPath);
-		}
-
 		public void SetDefaultIcon(BitmapImage img)
 		{
 			NeedsPlaceholderGlyph = false;

src/Files.App/Filesystem/RecentItems.cs

@@ -202,14 +202,6 @@ public bool UnpinFromRecentFiles(string path)
 			}
 		}
 
-		/// <summary>
-		/// Returns whether two RecentItem enumerables have the same order.
-		/// This function depends on `RecentItem` implementing IEquatable.
-		/// </summary>
-		private bool RecentItemsOrderEquals(IEnumerable<RecentItem> oldOrder, IEnumerable<RecentItem> newOrder)
-		{
-			return oldOrder != null && newOrder != null && oldOrder.SequenceEqual(newOrder);
-		}
 		public void Dispose()
 		{
 			RecentItemsManager.Default.RecentItemsChanged -= OnRecentItemsChanged;