Added Support for Date Accessed and File Owner Properties

[VigneshVoid]

I have added support for two new properties similar to Windows Explorer. We can have a whole lot of properties from the list in the URL

https://docs.microsoft.com/en-us/windows/win32/properties/core-bumper

[yaira2]

Instead of getting the info from code behind in the properties dialog, we should do it in SelectedItemsPropertiesViewModel and bind the TextBlock in the properties dialog to the properties in the SelectedItemsPropertiesViewModel.

[VigneshVoid]

Sure will work on that and add in the next commit @yaichenbaum

[yaira2]

Is there a reason you added .Properties? I feel that is a little redundant in this case since SelectedItemsPropertiesViewModel is going to be limited to the file properties anyways.

[VigneshVoid]

I added to separate Main Item Properties from any visibility properties or any local properties need for the methods within ViewModel. So it will be easy to differentiate from Main and Local Method Properties.

Mainly for Code Readability. @yaichenbaum

[tsvietOK]

I don't think it is really useful to display item owner in Properties dialog. @yaichenbaum What do you think about it?
Moreover, you displaying "File owner" even if item is folder.
However properties retrieving way you offered could be useful in the future.

[yaira2]

@tsvietOK I agree that it's a bit much, what we can do is add a feature flag for this to the experimental page and if a large percentage of users turn it on we can look into making this the default.

[yaira2]

@xpoppyx At some point we can do that, but I think we should get the basics first, for example, showing multiple dialogs if the user clicked properties when multiple files are selected.

[VigneshVoid]

"showing multiple dialogs if the user clicked properties when multiple files are selected."

@yaichenbaum supported the above requirement in this commit

[yaira2]

@VoidExploiter I actually made a mistake in the above comment, I should have said support for properties when opening the dialog when multiple items are selected. We can definitely explore keeping this but my thoughts are that when users select multiple files and hit "properties", they will want to know the size of all of them together and other information once it's extended.

[VigneshVoid]

We can provide a settings to open properties in individual windows for multiple files or on same window.

I will work on that and also opening a window with a combined properties.

[yaira2]

@VoidExploiter Can you add the setting to the experimental settings page? This pull request is looking very good so far 🙂.

[VigneshVoid]

Sure will add multiple windows and also file owner flag in that

[VigneshVoid]

@yaichenbaum Moved File Owner and Multiple windows to Experimental Flag

[yaira2]

@VoidExploiter Can you add strings for the new text that you added?

[yaira2]

I added to separate Main Item Properties from any visibility properties or any local properties need for the methods within ViewModel. So it will be easy to differentiate from Main and Local Method Properties.

Mainly for Code Readability. @yaichenbaum

I don't think this is necessary, as anything this ViewModel is already for item properties.

[VigneshVoid]

Okay will add the strings and move properties Model back into ViewModel

[VigneshVoid]

I added to separate Main Item Properties from any visibility properties or any local properties need for the methods within ViewModel. So it will be easy to differentiate from Main and Local Method Properties.
Mainly for Code Readability. @yaichenbaum

I don't think this is necessary, as anything this ViewModel is already for item properties.

Removed in this commit

[VigneshVoid]

@VoidExploiter Can you add strings for the new text that you added?

Added for English here. Do I need to add for other languages too?

[yaira2]

Please address the above comments.