Improve performance on selection operations #1063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hez2010
changed the title
ghost
added
the
|
@hez2010 Will this work for the grid layouts as well? |
yaira2
changed the title
yaira2
approved these changes
Jun 14, 2020
yaira2
added
ready to merge
|
@hez2010 Great work! I am not sure about inverting the selection but it's a already a great improvement for selecting and clearing the selection. |
|
I have not tested this with grid layout yet, but I think it should work. |
|
Update: Grid layout uses a separated logic for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataGrid.SelectAll()to make Select All operation as fast as Ctrl+AA further question:
How to optimize Invert Selection? DataGrid used
SetRowsSelection()internally for fast selection operation, I think we can make it use for implementing faster Invert Selection.https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/4aca25975f3cec90d4f86d5b5239aa6bc185880b/Microsoft.Toolkit.Uwp.UI.Controls.DataGrid/DataGrid/DataGridRows.cs#L797