New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes & improvements for Recent Items #10760

Merged

yaira2 merged 17 commits into files-community:main from gave92:rec_items

Dec 22, 2022

Member

gave92 commented Dec 18, 2022 •

edited

Resolved / Related Issues
Items resolved / related issues by this PR.

Fixes the issues listed in the comments below

Validation
How did you test these changes?

Built and ran the app

QuaintMako and others added 13 commits

December 15, 2022 22:30


          Fixed crash when going from Network to Recycle Bin

5f8d47b


          Added comment to clarify catch use

29811b3


          Revert "Added comment to clarify catch use"

644a1e9

This reverts commit 29811b3.


          Added comment to clarify catch use

39a987f


          Fix shell items path handling

2a60d70


          Add back try catch to GetFile

355544b


          Clarified comment

b576f20


          [WIP] Recent items

286da00


          Open recent folders in Files

089f4f9


          Fix crash when browsing shell folders

a68937e


          Improve remove

40e6c53


          Filter folders

bacade6


          Merge branch 'main' of https://github.com/files-community/Files into …

2267abe

…rec_items

gave92 commented

View reviewed changes

src/Files.App/Filesystem/RecentItems.cs Show resolved Hide resolved

gave92 commented

View reviewed changes

src/Files.App/Filesystem/RecentItems.cs Show resolved Hide resolved

gave92 commented

View reviewed changes

src/Files.App/Filesystem/RecentItems.cs Show resolved Hide resolved

gave92 commented

View reviewed changes

src/Files.App/Filesystem/StorageEnumerators/Win32StorageEnumerator.cs Show resolved Hide resolved

gave92 commented

View reviewed changes

src/Files.App/Helpers/FileOperationsHelpers.cs Show resolved Hide resolved

gave92 commented

View reviewed changes

src/Files.App/Shell/ShellFolderExtensions.cs Show resolved Hide resolved

gave92 commented

View reviewed changes

src/Files.App/Shell/ShellFolderExtensions.cs Show resolved Hide resolved

gave92 commented

View reviewed changes

src/Files.App/Shell/ShellFolderExtensions.cs Show resolved Hide resolved

gave92 commented

View reviewed changes

src/Files.App/UserControls/Widgets/RecentFilesWidget.xaml.cs Show resolved Hide resolved

gave92 commented

View reviewed changes

src/Files.App/Views/WidgetsPage.xaml.cs Show resolved Hide resolved


          Avoid using Any() in loop

03da295

gave92 force-pushed the rec_items branch from ddd48a9 to 03da295 Compare

December 19, 2022 20:05

gave92 marked this pull request as ready for review

December 19, 2022 20:06


          Merge branch 'main' into rec_items

54c5f70

jiejasonliu reviewed

View reviewed changes

src/Files.App/UserControls/Widgets/RecentFilesWidget.xaml.cs Outdated Show resolved Hide resolved

Member

yaira2 commented Dec 21, 2022

@gave92 can you look at the conflicts?


          Merge branch 'main' of https://github.com/files-community/Files into …

86da570

…rec_items

Member Author

gave92 commented Dec 22, 2022

Done!


          Only load icon once

yaira2 approved these changes

View reviewed changes

Member

yaira2 left a comment

LGTM

yaira2 merged commit 3b5ab67 into files-community:main

gave92 deleted the rec_items branch

December 22, 2022 00:41

yaira2 added the ready to merge label

jiejasonliu mentioned this pull request

Performance: Optimized the recent files widget #10867

Merged

2 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment