Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Naming an item at its creation properly sets the name #11060

Merged

Conversation

QuaintMako
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

What has been done

  • Properly registering the additional data in the dynamic dialog factory.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots
Renaming

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 42bc72a into files-community:main Jan 23, 2023
@QuaintMako QuaintMako deleted the 11059_FolderNamingNotWorking branch February 21, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Creating a new file or folder wont use set name
2 participants