Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Start a search when clicking tags in the details layout #11225

Merged
merged 2 commits into from Feb 9, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@yaira2
Copy link
Member

yaira2 commented Feb 9, 2023

Really nice! Do you want to add a VisualState that changes the background when hovered over?

@ferrariofilippo
Copy link
Contributor Author

Really nice! Do you want to add a VisualState that changes the background when hovered over?

Ok, I'm also working on #11218 and I think I'll push it in this branch since I'll need ItemTapped event

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2
Copy link
Member

yaira2 commented Feb 9, 2023

@ferrariofilippo let's merge this PR without the hover affect. Once #11218 is implemented, it might be better to only change the mouse cursor.

@yaira2 yaira2 merged commit 58a80d0 into files-community:main Feb 9, 2023
@ferrariofilippo
Copy link
Contributor Author

@ferrariofilippo let's merge this PR without the hover affect. Once #11218 is implemented, it might be better to only change the mouse cursor.

I was thinking of flipping the tag icon with a cross

@yaira2
Copy link
Member

yaira2 commented Feb 9, 2023

I like that idea 👍

@ferrariofilippo ferrariofilippo deleted the Tag_Search_Details branch February 9, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Start a search when clicking tags in the details layout
2 participants