Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Improve Column View #11344

Merged
merged 6 commits into from Feb 17, 2023
Merged

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues
Items resolved / related issues by this PR.

Details

  • When a directory is opened in column view, any folder pinned to favorites starts from the directory and everything else from root.
  • When the navigation button is clicked or the application relaunches to show column view, the last opened directory is displayed (not the last focused directory).

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@hishitetsu hishitetsu closed this Feb 17, 2023
@hishitetsu hishitetsu deleted the ImproveColumnView branch February 17, 2023 15:41
@hishitetsu hishitetsu restored the ImproveColumnView branch February 17, 2023 16:06
@hishitetsu hishitetsu reopened this Feb 17, 2023
@hishitetsu
Copy link
Member Author

It seems that I accidentally deleted the Pull Request branch when I meant to delete the branch for WIP. I have restored.

@yaira2
Copy link
Member

yaira2 commented Feb 17, 2023

It looks like the arrow key navigation for switching between columns is broken, it seems that this issue can be fixed if we close columns that aren't focused.

@hishitetsu
Copy link
Member Author

Fixed

yaira2
yaira2 previously approved these changes Feb 17, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit c96378f into files-community:main Feb 17, 2023
@hishitetsu hishitetsu deleted the ImproveColumnView branch February 17, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants