Properties: Fix some properties loading on older systems #1145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
approved these changes
Jun 19, 2020
yaira2
added
the
ready to merge
hez2010
reviewed
Jun 21, 2020
| @@ -332,7 +331,6 @@ public async Task GetPropertiesAsync(CancellationTokenSource _tokenSource) | |||
| catch (Exception ex) | |||
| { | |||
| NLog.LogManager.GetCurrentClassLogger().Error(ex, ex.Message); | |||
| ItemMD5HashProgress.Value = ItemMD5HashProgress.Maximum; | |||
There was a problem hiding this comment.
If ShowError is true, the color of ProgressBar will become yellow to indicate that there're errors occurred.
However, if the value of ProgressBar is 0, user won't know that the progress of calculation failed because nothing becomes yellow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize code