Skip to content

Modify context menu options for executable and installer files #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Jun 25, 2020
Merged

Modify context menu options for executable and installer files #1155

merged 25 commits into from
Jun 25, 2020

Conversation

jaigak
Copy link
Contributor

@jaigak jaigak commented Jun 20, 2020

Implements and closes #606.

@ghost ghost added the needs - code review label Jun 20, 2020
jaigak and others added 4 commits June 21, 2020 08:50
Co-authored-by: Yair Aichenbaum <39923744+yaichenbaum@users.noreply.github.com>
Co-authored-by: Yair Aichenbaum <39923744+yaichenbaum@users.noreply.github.com>
Co-authored-by: Yair Aichenbaum <39923744+yaichenbaum@users.noreply.github.com>
@yaira2 yaira2 added changes requested Changes are needed for this pull request and removed needs - code review labels Jun 21, 2020
jaigak and others added 3 commits June 22, 2020 12:33
Co-authored-by: Yair Aichenbaum <39923744+yaichenbaum@users.noreply.github.com>
Co-authored-by: Yair Aichenbaum <39923744+yaichenbaum@users.noreply.github.com>
Co-authored-by: Yair Aichenbaum <39923744+yaichenbaum@users.noreply.github.com>
@jaigak
Copy link
Contributor Author

jaigak commented Jun 23, 2020

Please don't merge yet.

@jaigak jaigak changed the title Add the option to run an executable as an administrator Modify context menu options for executable and installer files Jun 23, 2020
@jaigak jaigak marked this pull request as draft June 23, 2020 14:37
@jaigak jaigak marked this pull request as ready for review June 24, 2020 02:59
@ghost ghost added the needs - code review label Jun 24, 2020
@jaigak
Copy link
Contributor Author

jaigak commented Jun 24, 2020

You can merge now. I've also added the option to run as another user. This option is hidden in File Explorer however I included it by default in Files UWP since it'd be helpful for users who have multiple user accounts.

@yaira2
Copy link
Member

yaira2 commented Jun 24, 2020

:shipit:

@yaira2 yaira2 requested a review from lukeblevins June 24, 2020 14:40
@yaira2 yaira2 removed the changes requested Changes are needed for this pull request label Jun 24, 2020
@lukeblevins lukeblevins self-requested a review June 25, 2020 16:53
@yaira2 yaira2 requested a review from tsvietOK June 25, 2020 17:01
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 25, 2020
@yaira2 yaira2 merged commit d2ac020 into files-community:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a run as admin option for .exe files
4 participants