Add support for Bitlocker #1159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
yaira2
requested review from
tsvietOK and
lukeblevins
and removed request for
tsvietOK
yaira2
requested changes
Jun 21, 2020
|
@gave92 This is great work! I made a few suggestions in order to improve the PR, once those are resolved we will merge the pull request. |
yaira2
added
changes requested
yaira2
requested changes
Jun 21, 2020
yaira2
approved these changes
Jun 21, 2020
yaira2
added
needs - code review
and removed
changes requested
tsvietOK
reviewed
Jun 21, 2020
yaira2
approved these changes
Jun 21, 2020
|
Please, resolve conflicts. |
|
I can ask for pw again if the drive does not unlock. Currently you have to click on the sidebar item again to get prompted for pw again. |
yaira2
approved these changes
Jun 22, 2020
|
@yaichenbaum please wait before merging. There's a bug I need to fix :) |
|
@yaichenbaum ok should be good now.
|
yaira2
reviewed
Jun 23, 2020
Changed dialog title & text
Added shield icon on dialog Show dialog on wrong pw
tsvietOK
suggested changes
Jun 24, 2020
yaira2
approved these changes
Jun 24, 2020
tsvietOK
approved these changes
Jun 25, 2020
yaira2
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1047
This PR adds support for bitlocker drives.
When the user clicks on a drive on the sidebar, this PR:
Some testing on a pc different from mine is probably in order 😄