Skip to content

Fix: Fixed issue where grouping by tags wouldn't show all items #11909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

ferrariofilippo
Copy link
Contributor

@ferrariofilippo ferrariofilippo commented Mar 30, 2023

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • [ x Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open a folder which contains both tagged and untagged items
    2. Select Group by Tag
    3. See that all items are grouped
    4. Refresh the page
    5. See that all items are under the Untagged group

Screenshots (optional)
1
2
3

@yaira2 yaira2 changed the title Fixed: Grouping by tags doesn't show all items Fix: Fixed issue where grouping by tags wouldn't show all items Mar 30, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 30, 2023
@yaira2 yaira2 merged commit 443a71e into files-community:main Mar 30, 2023
@ferrariofilippo ferrariofilippo deleted the Group_By_tag branch March 30, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants