Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed color conversion helpers #12036

Merged
merged 2 commits into from Apr 14, 2023
Merged

Fix: Fixed color conversion helpers #12036

merged 2 commits into from Apr 14, 2023

Conversation

lukeblevins
Copy link
Contributor

@lukeblevins lukeblevins commented Apr 10, 2023

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
N/A

@lukeblevins
Copy link
Contributor Author

@yaira2 fyi

@yaira2 yaira2 changed the title fix: color conversion helpers Fix: Fixed color conversion helpers Apr 10, 2023
@lukeblevins lukeblevins marked this pull request as ready for review April 10, 2023 10:22
Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works for me

Light B/A:
Before_Light (Telefono) After_Light (Telefono)

Dark B/A:
Before_Dark (Telefono) After_Dark (Telefono)

@yaira2 yaira2 merged commit a8b991d into files-community:main Apr 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Default color schemes have very little impact in the color scheme
3 participants