Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties: Add support for combined and drive properties #1211

Merged
merged 3 commits into from
Jun 24, 2020

Conversation

tsvietOK
Copy link
Contributor

@tsvietOK tsvietOK commented Jun 23, 2020

New combined properties:
image
New drive properties:
image
Thanks: #1097
Fixes #259

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jun 23, 2020
@JaiganeshKumaran
Copy link
Contributor

Will this fix #876?

@tsvietOK
Copy link
Contributor Author

@JaiganeshKumaran It will not show dates for drive properties at all.

@ghost ghost added the needs - code review label Jun 23, 2020
@yaira2
Copy link
Member

yaira2 commented Jun 24, 2020

@xpoppyx Being that Disk Cleanup is being deprecated in favor of Storage Sense, it would make sense to keep along the same path for Files UWP.

@yaira2 yaira2 merged commit c04daf4 into files-community:master Jun 24, 2020
@tsvietOK tsvietOK deleted the properties branch June 24, 2020 13:37
@JaiganeshKumaran
Copy link
Contributor

JaiganeshKumaran commented Jun 24, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs - code review ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants