Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed high CPU usage in the recent files widget #12169

Merged
merged 1 commit into from Apr 23, 2023
Merged

Fix: Fixed high CPU usage in the recent files widget #12169

merged 1 commit into from Apr 23, 2023

Conversation

hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented Apr 23, 2023 •
edited

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: High CPU Usage #12160

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

@hishitetsu hishitetsu changed the title Fix: Fix high cpu usage Fix: Fixed high CPU usage in the recent files widget Apr 23, 2023
@hishitetsu hishitetsu changed the base branch from main to service/2.4.67 April 23, 2023 13:12
yaira2
yaira2 approved these changes Apr 23, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 8c29e26 into files-community:service/2.4.67 Apr 23, 2023
2 checks passed
@hishitetsu hishitetsu deleted the FixHighCPUUsage branch April 23, 2023 14:12
yaira2
yaira2 reviewed Apr 24, 2023
View reviewed changes
src/Files.App/UserControls/Widgets/RecentFilesWidget.xaml
@@ -51,65 +52,64 @@
</ListView.ItemContainerStyle>
<ListView.ItemTemplate>
<DataTemplate x:DataType="fs:RecentItem">
<ListViewItem RightTapped="ListViewItem_RightTapped" ToolTipService.ToolTip="{x:Bind RecentPath}">
Copy link
Member

@yaira2 yaira2 Apr 24, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible that having a ListViewItem inside the ListViewItem template broke virtualization. In retrospect I should have caught this when the initial change was implemented. Anyways, the right click issue is back, but we can work around it by moving the right click event to the item container.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I did not check it enough. I have fixed it with reference to the implementation in the column layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: High CPU Usage
2 participants
@hishitetsu @yaira2