Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Refactored ContextMenu #12217

Merged

Conversation

hishitetsu
Copy link
Member

I don't think this will solve all problems, but I believe it is important to prevent further problems.

  • Fixed problem with COM objects not being properly discarded on context menu warm-up
  • Fixed problem where ThreadWithMesssageQueue was being used unnecessarily for shell extensions with no submenu. This will improve performance

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes #issue...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

@yaira2 yaira2 merged commit ea2bdc7 into files-community:service/2.4.69 Apr 27, 2023
1 check passed
@hishitetsu hishitetsu deleted the RefactorContextMenu branch April 27, 2023 04:01
hishitetsu added a commit to hishitetsu/Files that referenced this pull request Apr 27, 2023
hishitetsu added a commit to hishitetsu/Files that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants