Skip to content

Fix JSON loading when it's empty #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Fix JSON loading when it's empty #1224

merged 1 commit into from
Jun 24, 2020

Conversation

tsvietOK
Copy link
Contributor

It could happen, when previous app version crashing leaving json file empty.
When deserializing an empty file, it returns null object, which is caused an exception.

It could happen, when previous app version crashing leaving json file empty
@jaigak
Copy link
Contributor

jaigak commented Jun 24, 2020

Will this fix #710?

@ghost ghost added the needs - code review label Jun 24, 2020
@tsvietOK
Copy link
Contributor Author

@Jaiganeshkumaran It is not supposed to fix it.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 24, 2020
@yaira2 yaira2 merged commit 4a7d90e into files-community:master Jun 24, 2020
@tsvietOK tsvietOK deleted the json-fix branch June 24, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants