Skip to content

Feature: Changed drive tooltip position #12363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2023
Merged

Feature: Changed drive tooltip position #12363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29617f4
Feature: Changed drive tooltip position
yaira2 May 16, 2023
8e9cd01
Update SidebarControl.xaml
yaira2 May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Files.App/Helpers/GitHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public static async Task<bool> Checkout(string? repositoryPath, string? branch)
var options = new CheckoutOptions();
var isBringingChanges = false;

Analytics.TrackEvent($"Triggered git checkout");
Analytics.TrackEvent("Triggered git checkout");

if (repository.RetrieveStatus().IsDirty)
{
Expand Down
6 changes: 3 additions & 3 deletions src/Files.App/UserControls/SidebarControl.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
x:Class="Files.App.UserControls.SidebarControl"
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
xmlns:converters="using:Files.App.Converters"
xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
xmlns:dataitems="using:Files.App.Data.Items"
xmlns:helpers="using:Files.App.Helpers"
xmlns:local="using:Files.App.UserControls"
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
xmlns:mconv="using:CommunityToolkit.WinUI.UI.Converters"
xmlns:converters="using:Files.App.Converters"
xmlns:dataitems="using:Files.App.Data.Items"
HorizontalAlignment="Stretch"
Collapsed="NavigationView_Collapsed"
DisplayModeChanged="SidebarControl_DisplayModeChanged"
Expand Down Expand Up @@ -99,7 +99,7 @@
Tag="{x:Bind Path}"
Visibility="{x:Bind ItemVisibility}">
<ToolTipService.ToolTip>
<ToolTip>
<ToolTip Placement="Right">
<StackPanel>
<!-- Displays the drive name, this is hidden when the extended details are shown -->
<TextBlock
Expand Down