Skip to content

Conversation

hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented Jun 10, 2023

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

@hishitetsu hishitetsu marked this pull request as draft June 10, 2023 08:01
@hishitetsu hishitetsu changed the title Fix: Fixed multiselect in column layout Fix: Fixed issue with opening and closing folder in column layout Jun 10, 2023
@hishitetsu hishitetsu marked this pull request as ready for review June 10, 2023 13:33
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jun 11, 2023
@yaira2 yaira2 merged commit 1654ab9 into files-community:main Jun 11, 2023
@hishitetsu hishitetsu deleted the FixColumnLayoutSelection branch June 11, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Deleting folder in column layout doesn't close it Bug: Multiselect with ctrl doesn't close unfocused columns
2 participants