Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where the icon was missing from the "new shortcut" option #12671

Merged
merged 4 commits into from Jun 21, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jun 20, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Context menu is mising icon for "New shortcut" #12668...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Right click empty space
    2. Expand the "new" menu
    3. Confirm the option for "shortcut" has an icon

Screenshots (optional)
Add screenshots here.

yaira2 and others added 2 commits June 21, 2023 14:39
Co-authored-by: hishitetsu <66369541+hishitetsu@users.noreply.github.com>
Co-authored-by: hishitetsu <66369541+hishitetsu@users.noreply.github.com>
@yaira2 yaira2 requested a review from hishitetsu June 21, 2023 21:08
@yaira2 yaira2 merged commit cea675e into main Jun 21, 2023
1 check passed
@yaira2 yaira2 deleted the ya/Shortcut branch June 21, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Context menu is mising icon for "New shortcut"
2 participants