Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Updated Git status icons #12910

Merged
merged 5 commits into from Jul 10, 2023
Merged

Feature: Updated Git status icons #12910

merged 5 commits into from Jul 10, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jul 10, 2023 •
edited

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes #issue...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 requested a review from 0x5bfa July 10, 2023 02:50
@yaira2 yaira2 changed the title Feature: Added color Git status icons Feature: Updated Git status icons Jul 10, 2023
0x5bfa
0x5bfa approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yaira2 yaira2 requested a review from 0x5bfa July 10, 2023 22:44
0x5bfa
0x5bfa approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@0x5bfa 0x5bfa left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me in terms of code quality.

Can you take a screenshot and paste here?

@yaira2 yaira2 merged commit 09f8c98 into main Jul 10, 2023
1 of 2 checks passed
@yaira2 yaira2 deleted the ya/GitIcons branch July 10, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x5bfa 0x5bfa 0x5bfa approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yaira2 @0x5bfa