New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Reduce splash screen display time for faster startup #13020

Merged

yaira2 merged 1 commit into files-community:main from hishitetsu:FasterLoading

Jul 21, 2023

Member

hishitetsu commented Jul 21, 2023

This PR modifies the splash screen loading wait to end as soon as the image loading is complete, rather than fixed at 500 ms.

Resolved / Related Issues

Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Closes #issue...

Validation
How did you test these changes?

Did you build the app and test your changes?
Did you check for accessibility? You can use Accessibility Insights for this.
Did you remove any strings from the en-us resource file?
- Did you search the solution to see if the string is still being used?
Did you implement any design changes to an existing feature?
- Was this change approved?
Are there any other steps that were used to validate these changes?


          Faster loading

0a91e47

yaira2 approved these changes

View reviewed changes

Member

yaira2 left a comment

LGTM

yaira2 added the ready to merge label

yaira2 merged commit 796ba9b into files-community:main

2 checks passed

hishitetsu deleted the FasterLoading branch

July 21, 2023 14:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment