Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Fixed issue with clicking search box #13158

Merged
merged 5 commits into from Aug 8, 2023
Merged

Code Quality: Fixed issue with clicking search box #13158

merged 5 commits into from Aug 8, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open a folder using Details Layout
    2. Click on the path bar or searchbox

@ferrariofilippo
Copy link
Contributor Author

ferrariofilippo commented Aug 8, 2023 •
edited

@yaira2 @hishitetsu this should prevent the bug

I'll test this more

@hishitetsu
Copy link
Member

When I single click once on an empty area, it works fine. But when I single click two or more times on an empty area, I can't type in the path bar.

@ferrariofilippo
Copy link
Contributor Author

ferrariofilippo commented Aug 8, 2023 •
edited

When I single click once on an empty area, it works fine. But when I single click two or more times on an empty area, I can't type in the path bar.

I see it, maybe it's sufficient to check if the next item to be focused is the listview, I'm trying this way
(To be sure, if you click twice on the path bar you can use it, right?)

@hishitetsu
Copy link
Member

(To be sure, if you click twice on the path bar you can use it, right?)

Yes, so this may be a minor issue.

@ferrariofilippo
Copy link
Contributor Author

ferrariofilippo commented Aug 8, 2023 •
edited

maybe it's sufficient to check if the next item to be focused is the listview, I'm trying this way

This works!
Still, when refocusing the listview, it will scroll to the top (also in preview)

hishitetsu
hishitetsu approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It certainly doesn't work well with refocusing, but it is still better than as is.

src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml.cs Outdated Show resolved Hide resolved
@ferrariofilippo
Copy link
Contributor Author

It certainly doesn't work well with refocusing, but it is still better than as is.

Why might open an issue to track that

@ferrariofilippo @hishitetsu
Update src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml.cs
b332f0d 
Co-authored-by: hishitetsu <66369541+hishitetsu@users.noreply.github.com>
hishitetsu
hishitetsu approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yaira2
yaira2 approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Fix: Cannot unfocus file list Code Quality: Fixed issue with clicking search box Aug 8, 2023
@yaira2 yaira2 added the approved label Aug 8, 2023
@yaira2 yaira2 merged commit 7f52809 into files-community:main Aug 8, 2023
1 check passed
@ferrariofilippo ferrariofilippo deleted the Fix_Click_Empty_Space branch August 8, 2023 18:12
yaira2 added a commit to QuaintMako/Files that referenced this pull request Aug 16, 2023
@yaira2
Squashed commit of the following:
15e2621 
commit 2b4132f
Author: Filippo Ferrario <102259289+ferrariofilippo@users.noreply.github.com>
Date:   Tue Aug 15 23:02:52 2023 +0200

    Code Quality: Create alike RichCommands inheritance (files-community#13155)

commit bd8c78f
Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com>
Date:   Wed Aug 16 05:50:24 2023 +0900

    Fix: Fixed issue where deleted items were displayed in tag search results (files-community#13202)

commit 4b5ed37
Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com>
Date:   Tue Aug 15 03:27:18 2023 +0900

    Fix: Fixed issue where closing the last closed tab would open it when starting the next session (files-community#13198)

commit 6e37d69
Author: Marco Franzen <mail@marco-franzen.de>
Date:   Mon Aug 14 16:17:14 2023 +0200

    Fix: Fixed crash that would occur when deleting or restoring files (files-community#13195)

commit 001e8eb
Author: Yair <39923744+yaira2@users.noreply.github.com>
Date:   Sun Aug 13 12:29:35 2023 -0400

    Preview: v2.5.22 (files-community#13190)

commit f77259a
Author: d2dyno <53011783+d2dyno1@users.noreply.github.com>
Date:   Sun Aug 13 17:28:48 2023 +0200

    Fix: Fixed issue where items in the Tags widget were not localized (files-community#13149)

commit 9c34c31
Author: Marcel Wagner <marcel.alex.wagner@outlook.com>
Date:   Sun Aug 13 16:20:48 2023 +0200

    Feature: Redesigned the left-hand sidebar (files-community#13052)

commit 3d88463
Author: Lukiluc29 <128183422+Lukiluc29@users.noreply.github.com>
Date:   Sun Aug 13 16:20:24 2023 +0200

    Fix: Fixed the corner radius on the drive details page (files-community#13179)

commit 89e3d03
Author: 0x5BFA <62196528+0x5bfa@users.noreply.github.com>
Date:   Thu Aug 10 09:14:38 2023 +0900

    Feature: Updated the design of the home page headers (files-community#13053)

commit f02c4a0
Author: Yair <39923744+yaira2@users.noreply.github.com>
Date:   Wed Aug 9 17:16:26 2023 -0400

    Feature: Increased the default width of the Git status column (files-community#13168)

commit c979c22
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Aug 9 00:55:38 2023 -0400

    Build(deps): Bump Microsoft.Data.Sqlite.Core from 7.0.9 to 7.0.10 (files-community#13163)

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit beae745
Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com>
Date:   Wed Aug 9 12:01:49 2023 +0900

    Fix: Fixed issue where the back button in the Properties window wasn't working properly (files-community#13162)

commit 7f52809
Author: Filippo Ferrario <102259289+ferrariofilippo@users.noreply.github.com>
Date:   Tue Aug 8 19:03:10 2023 +0200

    Code Quality: Fixed issue with clicking search box (files-community#13158)

    Co-authored-by: hishitetsu <66369541+hishitetsu@users.noreply.github.com>

commit 311b380
Author: Filippo Ferrario <102259289+ferrariofilippo@users.noreply.github.com>
Date:   Tue Aug 8 17:27:37 2023 +0200

    Fix: Fixed an issue where clicking an empty space would scroll to the top of the file list (files-community#13157)

commit 0988113
Author: Filippo Ferrario <102259289+ferrariofilippo@users.noreply.github.com>
Date:   Tue Aug 8 17:21:34 2023 +0200

    Feature: Show BitLocker options in main menu for drives (files-community#13142)

commit 3221267
Author: Filippo Ferrario <102259289+ferrariofilippo@users.noreply.github.com>
Date:   Tue Aug 8 17:17:48 2023 +0200

    Feature: Display error message when transferring files that are too large for FAT32 (files-community#13137)

commit be42aea
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Aug 8 10:30:20 2023 -0400

    Build(deps): Bump Vanara.Windows.Shell from 3.4.15 to 3.4.16 (files-community#13153)

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 53d99af
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Aug 8 08:37:00 2023 -0400

    Build(deps): Bump Vanara.PInvoke.Mpr from 3.4.15 to 3.4.16 (files-community#13152)

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 43624b3
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Aug 8 08:36:50 2023 -0400

    Build(deps): Bump Vanara.Windows.Extensions from 3.4.15 to 3.4.16 (files-community#13151)

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit e7281fe
Author: Yair <39923744+yaira2@users.noreply.github.com>
Date:   Mon Aug 7 21:39:09 2023 -0400

    Fix: Fixed issue where clicking DataGrid headers didn't change the sort direction (files-community#13150)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuaintMako QuaintMako QuaintMako left review comments

@yaira2 yaira2 yaira2 approved these changes

@hishitetsu hishitetsu hishitetsu approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ferrariofilippo @hishitetsu @yaira2 @QuaintMako