-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Fix: Fixed an issue where folders would open when using the selection rectangle in Columns Layout #13598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I still see the sub folder open for a moment before it closes again. |
When I select multiple folders, the first folder always opens. |
One change I would suggest is that if the user finishes the selection and only one folder is selected, we should open the sub folder for that. |
Seems much better to me! |
This even addresses this issue: #13600 |
Why open the latest folder? |
|
This patch looks very good to me and effectively fixes the issue. |
The behavior looks good. Can you add some code comments so we don't break this in the future? |
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you very much for this correction. |
Resolved / Related Issues
Closes Bug: Issue with selection rectangle in the column layout #13418
Validation
How did you test these changes?
Screenshots (optional)
https://github.com/files-community/Files/assets/59918974/6d086769-1fe8-4e15-a6d4-b3fb88821369