Skip to content

Conversation

heftymouse
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Issue with selection rectangle in the column layout #13418

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
https://github.com/files-community/Files/assets/59918974/6d086769-1fe8-4e15-a6d4-b3fb88821369

@yaira2
Copy link
Member

yaira2 commented Oct 29, 2023

I still see the sub folder open for a moment before it closes again.

@yaira2 yaira2 changed the title Fix: Do not open subfolders when using selection rectangle in column view Fix: Don't open subfolders when using selection rectangle in column view Oct 29, 2023
@Lukiluc29
Copy link
Contributor

When I select multiple folders, the first folder always opens.

@yaira2
Copy link
Member

yaira2 commented Oct 29, 2023

One change I would suggest is that if the user finishes the selection and only one folder is selected, we should open the sub folder for that.

@Lukiluc29
Copy link
Contributor

Seems much better to me!

@Lukiluc29
Copy link
Contributor

This even addresses this issue: #13600

@Lukiluc29
Copy link
Contributor

Why open the latest folder?

@heftymouse
Copy link
Contributor Author

heftymouse commented Oct 29, 2023

Why open the latest folder?

You're gonna have to take that up with @yaira2 lol
EDIT: i completely misread the comment. pls ignore

@Lukiluc29
Copy link
Contributor

This patch looks very good to me and effectively fixes the issue.

@yaira2
Copy link
Member

yaira2 commented Oct 29, 2023

The behavior looks good. Can you add some code comments so we don't break this in the future?

heftymouse and others added 3 commits October 29, 2023 23:57
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com>
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 29, 2023
@yaira2 yaira2 merged commit dff8f65 into files-community:main Oct 29, 2023
@yaira2 yaira2 changed the title Fix: Don't open subfolders when using selection rectangle in column view Fix: Fixed an issue where folders would open when using the selection rectangle in Columns Layout Oct 29, 2023
@Lukiluc29
Copy link
Contributor

Thank you very much for this correction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Issue with selection rectangle in the column layout
3 participants