Skip to content

Fix: Fixed warnings in settings #13968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2023
Merged

Fix: Fixed warnings in settings #13968

merged 1 commit into from
Nov 20, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Nov 19, 2023

Resolved / Related Issues

  • Fixed warnings in settings

hishitetsu
hishitetsu approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 5fc74c7 into main Nov 20, 2023
@yaira2 yaira2 deleted the ya/FixWarningsSettings branch November 20, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@hishitetsu hishitetsu hishitetsu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
needs - code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaira2 @hishitetsu