-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add the option to open more than one specific pages on startup #1443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update to head
Update to main repo latest version
@ChihweiLHBird Could you share a screenshot of the page? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the content from 'Open a specific page' to 'Open a specific page or pages'. Also, update the resource file.
|
The content has been updated. How to update the resource file? Does Visual Studio do it automatically? |
Under the strings folder, edit the resources.resw file in the en-US folder and then build the project to apply to resource files for other languages. |
My Visual Studio does not apply it to other languages when building the project... |
You need to install the Multilingual App Toolkit Extension. |
Instead of 'delete page' and 'edit page', it would be better if it says 'remove page' and 'change page location'. |
How about "Change Page"? |
First of all, these are not pages but locations. So change page location should be more appropriate. |
Okay, and it is updated. |
Make the edit button before the change buttons. It looks weird to me, |
How is it now? |
Great! |
I am going to the bed. Let me know if you find some other issues. I will fix them tomorrow. (●'◡'●) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you like left margin (of the add button) to be 10 or a higher value? |
@ChihweiLHBird Look's great! Here's some final feedback:
|
@xpoppyx It is just an example, we could leave it at the right side. |
Co-authored-by: Yair Aichenbaum <39923744+yaichenbaum@users.noreply.github.com>
Attempted to solve issue: #1316