Skip to content

Conversation

ChihweiLHBird
Copy link
Contributor

@ChihweiLHBird ChihweiLHBird commented Jul 14, 2020

Attempted to solve issue: #1316

@jaigak
Copy link
Contributor

jaigak commented Jul 14, 2020

@ChihweiLHBird Could you share a screenshot of the page?

Copy link
Contributor

@jaigak jaigak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the content from 'Open a specific page' to 'Open a specific page or pages'. Also, update the resource file.

@ghost ghost added the needs - code review label Jul 14, 2020
@ChihweiLHBird
Copy link
Contributor Author

@ChihweiLHBird Could you share a screenshot of the page?

image

@ChihweiLHBird
Copy link
Contributor Author

Change the content from 'Open a specific page' to 'Open a specific page or pages'. Also, update the resource file.

The content has been updated. How to update the resource file? Does Visual Studio do it automatically?

@jaigak
Copy link
Contributor

jaigak commented Jul 14, 2020

Change the content from 'Open a specific page' to 'Open a specific page or pages'. Also, update the resource file.

The content has been updated. How to update the resource file? Does Visual Studio do it automatically?

Under the strings folder, edit the resources.resw file in the en-US folder and then build the project to apply to resource files for other languages.

@ChihweiLHBird
Copy link
Contributor Author

Change the content from 'Open a specific page' to 'Open a specific page or pages'. Also, update the resource file.

The content has been updated. How to update the resource file? Does Visual Studio do it automatically?

Under the strings folder, edit the resources.resw file in the en-US folder and then build the project to apply to resource files for other languages.

My Visual Studio does not apply it to other languages when building the project...

@jaigak
Copy link
Contributor

jaigak commented Jul 14, 2020

My Visual Studio does not apply it to other languages when building the project...

You need to install the Multilingual App Toolkit Extension.

@jaigak
Copy link
Contributor

jaigak commented Jul 14, 2020

Instead of 'delete page' and 'edit page', it would be better if it says 'remove page' and 'change page location'.

@ChihweiLHBird
Copy link
Contributor Author

Instead of 'delete page' and 'edit page', it would be better if it says 'remove page' and 'change page location'.

How about "Change Page"?

@jaigak
Copy link
Contributor

jaigak commented Jul 14, 2020

Instead of 'delete page' and 'edit page', it would be better if it says 'remove page' and 'change page location'.

How about "Change Page"?

First of all, these are not pages but locations. So change page location should be more appropriate.

@ChihweiLHBird
Copy link
Contributor Author

Okay, and it is updated.

@jaigak
Copy link
Contributor

jaigak commented Jul 14, 2020

Make the edit button before the change buttons. It looks weird to me,

@ChihweiLHBird
Copy link
Contributor Author

How is it now?

@jaigak
Copy link
Contributor

jaigak commented Jul 14, 2020

How is it now?

Great!

@ChihweiLHBird
Copy link
Contributor Author

I am going to the bed. Let me know if you find some other issues. I will fix them tomorrow. (●'◡'●)

@lukeblevins lukeblevins self-requested a review July 14, 2020 18:07
@ChihweiLHBird ChihweiLHBird requested a review from tsvietOK July 15, 2020 01:25
Copy link
Contributor

@tsvietOK tsvietOK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Still not aligned to the left

@tsvietOK
Copy link
Contributor

image
And it is better to change Add page text to "Plus" button and make it little bit smaller.

@ChihweiLHBird
Copy link
Contributor Author

image
Still not aligned to the left

Sorry about that. It should be okay now.
image

@ChihweiLHBird
Copy link
Contributor Author

image
And it is better to change Add page text to "Plus" button and make it little bit smaller.

What icon is it?

@tsvietOK
Copy link
Contributor

image
And it is better to change Add page text to "Plus" button and make it little bit smaller.

What icon is it?

Glyph=""

@tsvietOK
Copy link
Contributor

@ChihweiLHBird
image

@ChihweiLHBird
Copy link
Contributor Author

@ChihweiLHBird
image

Would you like left margin (of the add button) to be 10 or a higher value?

@lukeblevins
Copy link
Contributor

@ChihweiLHBird Look's great! Here's some final feedback:

  • Add text back to button
  • Fix alignment with pages text with controls below

@tsvietOK
Copy link
Contributor

@xpoppyx It is just an example, we could leave it at the right side.
@duke7553 I think it is better when button text(Add pages) is not repeating text before button(Pages), but you have the final say.

@ChihweiLHBird
Copy link
Contributor Author

I would prefer the one come with Edge.
image

@ChihweiLHBird
Copy link
Contributor Author

image

Everyone, how is this?

ChihweiLHBird and others added 3 commits July 14, 2020 19:34
Co-authored-by: Yair Aichenbaum <39923744+yaichenbaum@users.noreply.github.com>
@yaira2 yaira2 merged commit 06d3de2 into files-community:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants