Skip to content

Conversation

soumyamahunt
Copy link
Contributor

Fixed #1229 and typo for environment variable.

Copy link
Contributor

@lukeblevins lukeblevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are good changes

@lukeblevins lukeblevins added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jul 14, 2020
@yaira2 yaira2 self-requested a review July 14, 2020 18:34
@yaira2 yaira2 merged commit ba0bd5a into files-community:master Jul 14, 2020
@soumyamahunt soumyamahunt deleted the navigationbar-terminal branch July 15, 2020 04:46
@yaira2
Copy link
Member

yaira2 commented Jul 15, 2020

@soumyamahunt I can still reproduce this issue after merging your changes.

@soumyamahunt
Copy link
Contributor Author

@soumyamahunt I can still reproduce this issue after merging your changes.

Is it happening to all terminal profiles or specific ones, can you provide which terminal profiles are having issues??

@yaira2
Copy link
Member

yaira2 commented Jul 15, 2020

@soumyamahunt I can still reproduce this issue after merging your changes.

Is it happening to all terminal profiles or specific ones, can you provide which terminal profiles are having issues??

I am seeing the issue with all profiles.

@soumyamahunt
Copy link
Contributor Author

I am seeing the issue with all profiles.

I tried all default profiles and didn't have any issue in them, @duke7553 you having issue with this too??

WGrOqTvtbq

TYIMaCoQs8

aRi0nNsE3h

@yaira2
Copy link
Member

yaira2 commented Jul 16, 2020

@soumyamahunt It seems to be working fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launching terminal profiles from the navigation bar is not working correctly
3 participants