Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed language options #1469

Merged
merged 3 commits into from
Jul 15, 2020
Merged

Conversation

soumyamahunt
Copy link
Contributor

1. By default the language of the app syncs with system language.

ApplicationFrameHost_0u48bWLEgI

2. "Restart Required" is only displayed when the language of app is changed.

ApplicationFrameHost_LnxoiueGkJ

3. The name of the languages are shown in their native name and script.

ApplicationFrameHost_FjFVuyvarp

Copy link
Contributor

@JaiganeshKumaran JaiganeshKumaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of System Default use Windows default and don't make the D capital.

@JaiganeshKumaran
Copy link
Contributor

How did you get all the supported language? Did you install them from Windows Settings?

@ghost ghost added the needs - code review label Jul 15, 2020
@soumyamahunt
Copy link
Contributor Author

How did you get all the supported language? Did you install them from Windows Settings?

Windows.Globalization.ApplicationLanguages.ManifestLanguages will do the trick.

Instead of System Default use Windows default and don't make the D capital.

Ok.

@JaiganeshKumaran
Copy link
Contributor

@soumyamahunt It doesn't work that way. Windows.Globalization.ApplicationLanguages.ManifestLanguages will return the list of supported languages however you can only set the language if it's installed. By default, only resource files for the languages in your language list would be downloaded by the Microsoft Store. Setting a language that is not in the language list won't work. You can try it for yourself.

@tsvietOK
Copy link
Contributor

tsvietOK commented Jul 15, 2020

@soumyamahunt Please, check "Restart required" text visibility and readability on light theme.
@JaiganeshKumaran All languages are visible only in debug mode, when you build in release mode, only installed languages will be visible

@soumyamahunt
Copy link
Contributor Author

@soumyamahunt It doesn't work that way. Windows.Globalization.ApplicationLanguages.ManifestLanguages will return the list of supported languages however you can only set the language if it's installed. By default, only resource files for the languages in your language list would be downloaded by the Microsoft Store. Setting a language that is not in the language list won't work. You can try it for yourself.

Windows.Globalization.ApplicationLanguages.ManifestLanguages will return all the supported languages that are currently installed with the app. If during packaging of the app “Create App bundle” isn't set to "Never", when published to store Windows will only install the language which are currently installed by user in Windows settings. If devs want to make all the supported languages available to user they can just set “Create App bundle” to "Never". In any case, if you are wondering there is any chance of error there won't be any exception thrown.

@soumyamahunt Please, check "Restart required" text visibility and readability on light theme.

Will push a fix on that.

@JaiganeshKumaran All languages are visible only in debug mode, when you build in release mode, only installed languages will be visible

Not true actually, you can set “Create App bundle” to "Never" to show all supported languages even that are not installed in Windows settings.

@JaiganeshKumaran
Copy link
Contributor

All languages are visible only in debug mode, when you build in release mode, only installed languages will be visible

Not true actually, you can set “Create App bundle” to "Never" to show all supported languages even that are not installed in Windows settings.

But we shouldn't do that since it will increase the download size.

@yaira2
Copy link
Member

yaira2 commented Jul 15, 2020

How did you get all the supported language? Did you install them from Windows Settings?

When you build the app from the source you will see all the languages.

@yaira2 yaira2 self-requested a review July 15, 2020 15:18
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jul 15, 2020
@yaira2 yaira2 merged commit 5a62add into files-community:master Jul 15, 2020
@soumyamahunt soumyamahunt deleted the language-fix branch July 15, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants