Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Update layout size selection state #14845

Merged
merged 4 commits into from Feb 26, 2024
Merged

Feature: Update layout size selection state #14845

merged 4 commits into from Feb 26, 2024

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Feb 26, 2024

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    For Feature: Slider to control thumbnail size #10492...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Confirm the selection state in the layout flyout is correct for each view and size

Screenshots (optional)
image

Update LayoutAction.cs

Fix

Fix
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Looks good.
I like how the OpacityIcon is selected when slider value is being changed!

Medium = 2,
Large = 3,
ExtraLarge = 4,
Compact = 1,
Copy link
Member

@0x5bfa 0x5bfa Feb 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the first value has been changed?
Is that just your preference?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with either

@yaira2 yaira2 merged commit 1d7ae05 into main Feb 26, 2024
5 checks passed
@yaira2 yaira2 deleted the ya/SelectionIcons branch February 26, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants