Skip to content

Added the ability to use the escape key to exit the properties window #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 19, 2020
Merged

Added the ability to use the escape key to exit the properties window #1504

merged 6 commits into from
Jul 19, 2020

Conversation

winston-de
Copy link
Contributor

Added the ability to use the escape key to exit the file properties window as requested in issue #1409.

jaigak
jaigak previously approved these changes Jul 19, 2020
View reviewed changes
@ghost ghost added the needs - code review label Jul 19, 2020
yaira2
yaira2 previously approved these changes Jul 19, 2020
View reviewed changes
@yaira2 yaira2 requested a review from tsvietOK July 19, 2020 04:51
tsvietOK
tsvietOK suggested changes Jul 19, 2020
View reviewed changes
@yaira2 yaira2 added changes requested Changes are needed for this pull request and removed needs - code review labels Jul 19, 2020
@winston-de winston-de dismissed stale reviews from yaira2 and jaigak via df34bc2 July 19, 2020 18:35
@winston-de winston-de requested a review from tsvietOK July 19, 2020 18:57
tsvietOK
tsvietOK suggested changes Jul 19, 2020
View reviewed changes
@winston-de winston-de requested a review from tsvietOK July 19, 2020 20:03
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Jul 19, 2020
@yaira2 yaira2 merged commit 076db04 into files-community:master Jul 19, 2020
@yaira2 yaira2 mentioned this pull request Jul 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 left review comments

+2 more reviewers

@tsvietOK tsvietOK tsvietOK approved these changes

@jaigak jaigak jaigak left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@winston-de @tsvietOK @yaira2 @jaigak