-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Added the ability to resize the sidebar #1512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently sidebar can only be resized up to certain width. |
@soumyamahunt That would be the expected behavior. Does the app keep track of the size across sessions? |
No not now, I will add it. |
@soumyamahunt If you need any inspiration, check out the appropriate branch for my past, unfinished work on this. Looks really good so far. |
@yaichenbaum @duke7553 what should we keep minimum and maximum sidebar width?? |
I would recommend keeping the current size as the minimum. |
@yaichenbaum To match Fluent Design Guidelines, the minimum width must be at least 20% of the container. |
@soumyamahunt Could you share a screenshot on the changes? |
|
…s-uwp into resize-sidebar
@yaichenbaum, @duke7553 minimum width is kept at 200(as was before) maximum is kept at 500. Also, width is remembered across instances. |
Can you increase the minimum width to match the default WinUI styles?
|
I can but @yaichenbaum suggested to keep it same as before, @yaichenbaum what do you think of this?? Also what is the default width value in WinUI style?? |
@soumyamahunt Nope, we're happy with the existing minimum. |
Now the settings sidebar looks out of place. Could you use the same size for both NavigationView controls and also make Setting sidebar resizable? |
I don't think making settings sidebar resizable gonna improve any usability since the strings used there are static, but I can make it sync with the main sidebar. @yaichenbaum, is this something you would like too?? |
The settings sidebar should not be resizable. |
This pr tries to implement feature requested in #672.