Skip to content

Feature: Added set as app background action #15316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2024
Merged

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented May 6, 2024

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Splitting translation for background settings #15313...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Confirmed the "Set as app background" option is visible in the toolbar (for images)
    2. Confirmed the "Set as app background" option is visible in the context menu (for images)
    3. Confirmed the action sets the app background

Documentation

  • Added this action to the website repo (to be published when v3.4 goes live)
  • Added a screenshot to Crowdin

Screenshots (optional)
image
image

@yaira2 yaira2 requested a review from 0x5bfa May 6, 2024 15:05
@yaira2 yaira2 merged commit 7935234 into main May 6, 2024
@yaira2 yaira2 deleted the ya/SetAsAppBackground branch May 6, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Splitting translation for background settings
1 participant