Skip to content

Fixed app crashing when parsing terminal.json file #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

soumyamahunt
Copy link
Contributor

Tries fixing #710. If parsing fails app uses the default values while keeping user's copy intact (doesn't override user's copy).

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jul 23, 2020
@ghost ghost added the needs - code review label Jul 23, 2020
@yaira2 yaira2 merged commit 1037f9b into files-community:master Jul 23, 2020
@soumyamahunt soumyamahunt deleted the terminal-fix branch July 23, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants