Code Quality: Renamed ItemViewModel with ShellViewModel #15622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the goals here? |
|
Preparing Storage Abstraction (planning to finish codebase preparation in June or early July). This PR's rationale is this class is the view model of IShellPage and name of ItemViewModel may confuse us with StandardStorageItem(fka ListedItem). |
|
This PR seems to just be a rename, how does it further that goal? |
|
Wdym, I just made it more accurate. |
|
Good change! Hopefully it'll be less confusing |
yaira2
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Steps used to test these changes
None