Skip to content

Fix: Fixed an issue where changing icons didn't work when admin access was required #15625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 23, 2024

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jun 19, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files ...
  2. ...

@yaira2 yaira2 marked this pull request as draft June 19, 2024 02:26
@yaira2 yaira2 added the help wanted Extra attention is needed label Jun 19, 2024
@yaira2
Copy link
Member Author

yaira2 commented Jun 19, 2024

The script works when I run manually, but for some reason it's not working from start process.

Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's execution policy.

@yaira2
Copy link
Member Author

yaira2 commented Jun 19, 2024

I think there's execution policy.

There is that, but I already have it bypassed on my device so there must be another reason.

@yaira2 yaira2 added needs - code review and removed help wanted Extra attention is needed labels Jun 19, 2024
@yaira2 yaira2 marked this pull request as ready for review June 19, 2024 18:25
@yaira2
Copy link
Member Author

yaira2 commented Jun 19, 2024

This is ready for review

@yaira2 yaira2 changed the title Fix: Fixed issue where changing icons didn't work when admin access was required Fix: Fixed an issue where changing icons didn't work when admin access was required Jun 19, 2024
@yaira2 yaira2 requested a review from 0x5bfa June 20, 2024 20:45
@yaira2 yaira2 merged commit 9ee8447 into main Jun 23, 2024
@yaira2 yaira2 deleted the ya/PromptForAdminWhenChangingShortcutIcon branch June 23, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Admin prompt doesn't show when trying to change shortcut icon
2 participants