Implemented drop to sidebar items

[soumyamahunt]

Fixes #1049.

[soumyamahunt]

can you make them highlight when you drag over an item?
like this:

I haven't been able to do that, would you like to have a crack at this??

[soumyamahunt]

@xpoppyx @yaichenbaum reveal effect is now implemented:

[tsvietOK]

Why there is different actions for some folders?

[soumyamahunt]

Why there is different actions for some folders?

I have implemented different actions based on Windows Explorer. In Windows Explorer, if the item you are dragging is in the same drive as the destination folder the operation will be to move the item otherwise the item will be copied.

[tsvietOK]

Can't move or copy file. App crashing when drop file on side bar item.

2020-07-29 15:31:44.3932|ERROR|Files.App|Object reference not set to an instance of an object.|System.NullReferenceException: Object reference not set to an instance of an object.
   at Files.Interacts.Interaction.PasteItems(DataPackageView packageView, String destinationPath, DataPackageOperation acceptedOperation)
   at Files.Controls.SidebarControl.NavigationViewLocationItem_Drop(Object sender, DragEventArgs e)
   at System.Threading.WinRTSynchronizationContextBase.Invoker.InvokeCore()

[soumyamahunt]

Can't move or copy file. App crashing when drop file on side bar item.

2020-07-29 15:31:44.3932|ERROR|Files.App|Object reference not set to an instance of an object.|System.NullReferenceException: Object reference not set to an instance of an object.
   at Files.Interacts.Interaction.PasteItems(DataPackageView packageView, String destinationPath, DataPackageOperation acceptedOperation)
   at Files.Controls.SidebarControl.NavigationViewLocationItem_Drop(Object sender, DragEventArgs e)
   at System.Threading.WinRTSynchronizationContextBase.Invoker.InvokeCore()

Can you share more detail on what you were trying to copy and to what path??

[tsvietOK]

@soumyamahunt

[soumyamahunt]

@tsvietOK Does the error happen to you always?? I can't seem to reproduce it. Also the exception seems to be related to StatusBarControl and I haven't made any changes to it in this pr.

[tsvietOK]

I don't think it is a good idea to cancel user action (copy or move) if item already exists in folder.

[soumyamahunt]

I don't think it is a good idea to cancel user action (copy or move) if item already exists in folder.

What do you think should be the default behaviour?? Currently if the item is already present in the folder, when dragging over the same folder the glyph would prompt the user it cannot be dropped. This is the implemented behaviour in every drag-drop scenario app wide.

[tsvietOK]

Oh, sorry, I misunderstood you. All ok.

[soumyamahunt]

Oh, sorry, I misunderstood you. All ok.

What about the exception?? Are you still getting it??

[tsvietOK]

It is strange, but now i can't reproduce this issue anymore.

[soumyamahunt]

It is strange, but now i can't reproduce this issue anymore.

I think it is related to StatusBarControl, not this pr.