-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add support for shortcut files #1573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@gave92 You can't share a shortcut file even in Explorer but for .URL files we could share the link of the shortcut. |
Is it possible to create new shortcut files with this PR? |
@Jaiganeshkumaran I have yet to look into creating new shortcuts, currently you can only view and use existing ones. Ideally you should be able to create new shortcuts and edit existing ones in the Property window. |
@gave92 Don't share anything for LNK files since they mostly contain a local path and sharing it doesn't make sense unless the path is accessible from other PCs. Only share the link for URL files. |
@Jaiganeshkumaran now you can create shortcuts to files and folders from right-click context menu :) |
Can you create a shortcut from a selected folder? Please add an option to create shortcut from selected folder.
|
@Jaiganeshkumaran yes you can already do that 👍 |
Show thumbnail, use folder type for shortcuts to folders, hide pin-to-sidebar Improved icon, no open-with on shortcuts, fix share Support for renaming and deleting shortcuts Support for cutting/copying shortcuts Support for sharing shortcuts
Editable shortcuts props
@gave92 Sorry I couldn't get to this one earlier. To answer your questions:
Thank you for your work on this. |
@yaichenbaum So something like Pivot or horizontal NavigationView correct? |
If I recall correctly, it's recommended to use the NavigationView over the Pivot control. |
@xpoppyx Thanks for the feedback, I can confirm that at the moment ".url" files won't display the proper icon :/ |
Update shortcut icon
@xpoppyx should be fixed, note that it will be the hash of the shortcut target and not of the shortcut itself |
No, it's not. Not everyone knows what the INK extension means. |
@xpoppyx most of your notes should now be fixed:
Edit: getting the icon for ".url" files appears to be a bit complicated.. only the fulltrust process can get it (the same applies if you set a custom icon for the shortcut). I'll need to think on this. |
Can you increase Properties window height from 475 to 550? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disable MD5 has calculation for link item, as it is hash of the real file, not the link file.
@gave92 Why did you remove "Created" and "Accessed" fields for link files? |
@tsvietOK both were of the link target and not of the link itself (same as the md5 hash). |
Is it possible to don't display link file extension independently from "Show file extension" setting? |
This PR adds support for shortcut files (".lnk", ".url")
Related issue: #177
What works
What doesn't work
What's missing
Properties window could allow to edit shortcutsCreating new shortcuts(from context menu)Share a .url file as linkA decent icon on lnk/url files--> thanks @xpoppyx!Edit
@duke7553 We are now using 3 separate methods for supporting all file operations:
This leads to a bit of complication, also the
ItemViewModel
starts to look a bit messy/hackish. What do you think?Btw have you already made some progress on #632?